Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.06] backport using strings.Builder instead of string appending #1433

Merged
merged 1 commit into from
Oct 17, 2018
Merged

[18.06] backport using strings.Builder instead of string appending #1433

merged 1 commit into from
Oct 17, 2018

Conversation

thaJeztah
Copy link
Member

backport of #1423 for 18.06
fixes #1422 for 18.06

git checkout -b 18.06_backport_use_string_builder upstream/18.06
git cherry-pick -s -S -x 814ced4b30d0d2164c74d2f2007603ce81d0d17b

cherry-pick was clean; no conflicts

@denverdino @thaJeztah
Using strings.Builder instead of string appending
9a2ede8 
Signed-off-by: Li Yi <[email protected]>
(cherry picked from commit 814ced4)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 18.06.2 milestone Oct 10, 2018
vdemeester
vdemeester approved these changes Oct 11, 2018
View reviewed changes
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :coffee:

cpuguy83
cpuguy83 approved these changes Oct 17, 2018
View reviewed changes
Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 0366a4b into docker:18.06 Oct 17, 2018
@thaJeztah thaJeztah deleted the 18.06_backport_use_string_builder branch October 17, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Assignees
No one assigned
Labels
status/0-triage
Projects
None yet
Milestone
18.06.2
Development

Successfully merging this pull request may close these issues.
5 participants
@thaJeztah @vdemeester @cpuguy83 @GordonTheTurtle @denverdino