-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry support #635
Conversation
Just tested myself, works great. Not related to this PR but I also encountered an issue that seems linked to moby/buildkit#2162: |
@crazy-max Do you have a reproducer for this as haven't seen this myself. Not a blocker for this PR but create a tracking issue in Buildkit if you do. |
Yes I have a reproducer on a public repo. Will create an issue on BuildKit repo. |
@tonistiigi Looks like it has been fixed, can't repro anymore with |
Nice feature! log with traceID and spanID will be better. moby/buildkit#2235 |
@crazy-max Might be flaky. Don't know any change in the past days. |
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
when i use docker context with remote SSH I also have the next error
only change that was done for this part of code is replacing opentracing to opentelemetry lib but it somehow damaged this part for case when we use remote ssh docker context builder |
Depends on:
add current tracing context detection and exec propagation moby/buildkit#2163cli incompatible with moby master