Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress: fix missing last progress from loading layers #2876

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

tonistiigi
Copy link
Member

Because of the bugs in the logic of how layer progress is throttled the last event may never be written, leaving behind incomplete output like

 => importing to docker                                                                                   0.9s
 => => loading layer f0074c45c2c0 190B / 190B                                                             0.9s
 => => loading layer 0e8819756174 393.22kB / 38.08MB                                                      0.8s
 => => loading layer 63ec8d9b4ac7 144B / 144B                                                             0.0s

Fix by always updating the current values, even if an event is initially throttled and not shown, plus make sure it always gets updated in the map.

@tonistiigi tonistiigi merged commit 206bd6c into docker:master Jan 2, 2025
122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants