builder: validate buildkit configuration #2864
Conversation
crazy-max
force-pushed
the
builder-validate-config
branch
from
ac887c6 to
861f42a
Compare
| @@ -151,7 +152,11 @@ func LoadConfigTree(fp string) (*toml.Tree, error) { | |||
| defer f.Close() | |||
| t, err := toml.LoadReader(f) | |||
| if err != nil { | |||
| return t, errors.Wrap(err, "failed to parse config") | |||
| return t, errors.Wrap(err, "failed to parse buildkit config") | |||
| } | |||
There was a problem hiding this comment.
Wondering; will this be problematic when crating a builder using an older version of buildkit? (i.e. would validation only work correctly if the version matches the one that's vendored?)
There was a problem hiding this comment.
I don't think this will be an issue as we are backward compat. Also we are already using this logic to get the registry config in
buildx/store/storeutil/storeutil.go
Lines 125 to 128 in 567361d
There was a problem hiding this comment.
Ah yeah, I wasn't sure, so thought I'd mention it. I recall that I ran into changes in the garbage-collect configuration that changed, and for which I needed to make changes in moby/moby, because it used those; moby/moby#48634 (comment)
There was a problem hiding this comment.
Can we add a test for this, making sure a new unknown key doesn't cause a validation error.
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
builder-validate-config
branch
from
861f42a to
07db2be
Compare
fixes #2853
We should validate buildkit configuration before creating the builder.