Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't generate local state for subrequests #2754

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 25, 2024

Relates to https://github.com/docker/docs/actions/runs/11502549192/job/32017891983#step:6:21

Warning: Failed to export build record: /home/runner/work/_temp/docker-actions-toolkit-16m5IG/export/rec.dockerbuild not found

When generating build summary in our GitHub Actions, we are using the buildx.build.ref from metadata to export the build record. When using call, this attribute is not set:

buildx/build/build.go

Lines 525 to 526 in 746eadd

if opt.CallFunc == nil {
rr.ExporterResponse["buildx.build.ref"] = buildRef

Which is the right behavior as no build record is written for subrequests anyway.

But we also have a fallback in our GitHub Actions in case buildx.build.ref is not set that checks if a local state is available as part of this build. And in this case we have one as we are generating a local state for subrequests but I don't think it makes sense to do so.

cc @dvdksn

@crazy-max crazy-max added this to the v0.18.0 milestone Oct 25, 2024
@crazy-max crazy-max requested a review from tonistiigi October 25, 2024 09:07
@crazy-max crazy-max marked this pull request as ready for review October 25, 2024 09:07
@tonistiigi tonistiigi merged commit 2bdf451 into docker:master Oct 25, 2024
106 checks passed
@crazy-max crazy-max deleted the call-localstate branch October 25, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants