Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return backwards compatibility to the way we handle /usr/src/php/ext/* (especially for user-supplied subdirectories looking to utilize docker-php-ext-* for non-core modules) #288

Merged
merged 2 commits into from
Aug 10, 2016

Conversation

tianon
Copy link
Member

@tianon tianon commented Aug 9, 2016

Closes #269
Closes #268
Closes #266

tianon added 2 commits August 9, 2016 14:28
…* (especially for user-supplied subdirectories looking to utilize docker-php-ext-* for non-core modules)
@tianon
Copy link
Member Author

tianon commented Aug 9, 2016

The gist of how this works is:

  1. if /usr/src/php already exists when we start, we do not remove it (allows for dropping folders in /usr/src/php/ext/* as before)
  2. if we create /usr/src/php ourselves via extract, we delete it
  3. no more cache for existing extensions -- extracting is reasonably fast, and has to happen for actual build anyhow, so just do it sooner

@shouze
Copy link
Contributor

shouze commented Aug 10, 2016

LGTM

1 similar comment
@yosifkit
Copy link
Member

LGTM

@yosifkit yosifkit merged commit 882b9c2 into docker-library:master Aug 10, 2016
@yosifkit yosifkit deleted the backwards-compat branch August 10, 2016 16:32
tianon added a commit to infosiftr/stackbrew that referenced this pull request Aug 10, 2016
- `java`: 8u102 (Debian)
- `kibana`: 5.0.0-alpha5
- `logstash`: 5.0.0-alpha5
- `mariadb`: 5.5.51
- `php`: `--enable-ftp` (docker-library/php#287), backwards compatibility fixes (docker-library/php#288)
@partounian
Copy link

Sorry but I'm a bit new to this, and these past few issues have me confused. If I need PECL to install modules would I just use docker-php-ext-* now?

@tianon
Copy link
Member Author

tianon commented Aug 10, 2016

No, pecl is absolutely still appropriate to use directly -- the only docker-php-ext-* script which should be used when installing from pecl is docker-php-ext-enable (if needed).

This PR simply adds back semi-support for the strange way folks were dumping extension sources into subdirectories of /usr/src/php/ext and using docker-php-ext-* to build/install them.

@partounian
Copy link

Oh okay, well previously I was getting an issue for phpize previously, and couldn't figure out how to instal the Alpine dev package for that to fix the issue. Any pointers?

@yosifkit
Copy link
Member

@partounian, are you asking about figuring out which -dev is needed to install a specific php plugin (https://pkgs.alpinelinux.org/contents to find which package has the header file needed) or about installing general development tools for phpizing a plugin (RUN apk add --no-cache --virtual .phpize-deps $PHPIZE_DEPS && phpize ... && apk del .phpize-deps)?

@partounian
Copy link

Well I just need to install the plugins for APCu, and Graphicsmagick for PHP5.5. So my question is, what's the best way to get those installed? For gmagick I am already downloading the pkg with apk testing, but can't get the plugin installed with PECL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants