Remove extracted php src #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- swap spaces to tabs to match - use gnu tar for `--strip-components` - cache known extension list in `/usr/src/` - remove extra output
| && curl -fSL "http://php.net/get/$PHP_FILENAME.asc/from/this/mirror" -o "$PHP_FILENAME.asc" \ | ||
| && mkdir -p /usr/src \ | ||
| && cd /usr/src/ \ | ||
| && curl -fSL "http://php.net/get/$PHP_FILENAME/from/this/mirror" -o php.tar.xz \ |
|
LGTM |
| && cd /usr/src/php \ | ||
| && gpg --batch --verify php.tar.xz.asc php.tar.xz \ | ||
| && rm -r "$GNUPGHOME" \ | ||
| && docker-php-source extract \ |
There was a problem hiding this comment.
Since the tar file sticks around in the image after this point, couldn't we split this here and move the COPY down further? (ie, download PHP, then COPY, then RUN docker-php-source extract && ... etc)
There was a problem hiding this comment.
Slightly more explicitly stated:
ENV PHP_...
RUN curl ...
COPY docker-php-source ...
RUN docker-php-source ...
|
LGTM |
yosifkit
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jul 13, 2016
- `drupal` bump `8.1.6` and docker-library/drupal#51 - `haproxy` bump to `1.6.7` - `memcached` bump to `1.4.29` - `mongo` bump to `3.2.8` - `owncloud` docker-library/owncloud#74 and docker-library/owncloud#75 - `php` docker-library/php#256 - `tomcat` bump to `8.5.4` and `9.0.0.M9`
This was referenced Jul 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon and closes #245. Thanks to @shouze for all his work on this. I was debugging his changes and decided that it would be clearer to add my improvements on top.
Fixes #234.