Add official support for Backdrop CMS

[pirog]

Backdrop CMS is a fork of Drupal aimed at small to medium sized businesses and non-profits. You can read more about it at https://backdropcms.org/.

The Dockerfiles here borrow VERY HEAVILY from both the official drupal and wordpress images.

[jenlampton]

👍

[tianon]

Did a cursory review, and this is looking pretty good to me! (certainly some familiar code in here 😇 👍)

It looks like you've started on some of the documentation already in the README.md that should be pretty easy to convert to a PR against https://github.com/docker-library/docs (be sure to read the README.md file over there for some of the details about what the bits in that repo are).

Feel free to let us know if you run into any trouble or need any assistance with that!

[pirog]

LOL yeah @tianon. Figured it would be easier to approve if most of the code was yours anyway 👍 plus ABDFI.

I'll submit another PR over at https://github.com/docker-library/docs with relevant fixes re: its README.md

[pirog]

OK i've got a branch started on the docs over at https://github.com/pirog/docs/tree/backdropDocss but i'd like to get @jenlampton to do a pass on the docs before we submit a PR against the docs repo

[tianon]

Cool, sounds good! Just a quick comment that you'll want to drop both "backdrop/.DS_Store" and "backdrop/README.md" before you submit the PR (one's unnecessary, the other is autogenerated by a bot from the contents of other files). 👍

[pirog]

Bleh. Thanks for the QA there. Should be good now just need the content review and go ahead from @jenlampton

[tianon]

No worries, just wanting to save you from a little frustration later when you submit the PR and Travis balks. 😄

[pirog]

Ha. And we both know there is no scorn like Travis' scorn.

On Wed, Apr 6, 2016 at 2:19 PM, Tianon Gravi [email protected]
wrote:

No worries, just wanting to save you from a little frustration later when
you submit the PR and Travis balks. 😄

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1584 (comment)

[jenlampton]

@pirog Is this what I should be reviewing? https://github.com/pirog/docs/blob/backdropDocs/backdrop/content.md

[pirog]

Yes! https://github.com/pirog/docs/blob/backdropDocs/backdrop/content.md

[jenlampton]

Looks great @pirog I just submitted a PR with a few teeny changes :) 👍

[pirog]

@jenlampton merged! and...... here is the PR against the docs repo https://github.com/docker-library/docs/pull/540/files

[yosifkit]

LGTM, Build test of #1584; c714606 (backdrop):

$ bashbrew build "backdrop"
Cloning backdrop (git://github.com/backdrop-ops/backdrop-docker) ...
Processing backdrop:1.3.4 ...
Processing backdrop:1.3 ...
Processing backdrop:1 ...
Processing backdrop:1.3.4-apache ...
Processing backdrop:1.3-apache ...
Processing backdrop:1-apache ...
Processing backdrop:apache ...
Processing backdrop:latest ...
Processing backdrop:1.3.4-fpm ...
Processing backdrop:1.3-fpm ...
Processing backdrop:1-fpm ...
Processing backdrop:fpm ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing backdrop:1.3.4
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing backdrop:1.3.4-fpm
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed

[tianon]

LGTM pending docs fixes 👍