Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content.md #2535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

andanders
Copy link

correct filename

correct filename
@tianon
Copy link
Member

tianon commented Jan 30, 2025

In the future, please update your existing pull request instead of creating a new one (#2534; https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request#making-changes-to-files-in-your-pull-request).

cc ros image maintainer @tfoote -- this looks correct to me, but I'd love if you could confirm 🙇

Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rolling back to the old syntax. We switched to the _launch format 2 years ago: ros2/demos#588 This should be the correct syntax for all versions after Humble.

We could add a side comment for Humble and older to use the alternative syntax, and support that until Humble goes EOL. But I would be inclined to keep this as targeted for the default version.

What's your usage @andanders ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants