-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add official Friendica docs #1551
Conversation
7e72ad1
to
bc9cfa3
Compare
bc9cfa3
to
656ea9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this seems OK, just a few minor adjustments I'd suggest.
It might also be worthwhile to trim this down (like only providing one example stack.yml
instead of two explicit and one implied) and providing the additional examples/details over in the GitHub repo which this can then link to ("find more examples for different scenarios over at XYZ").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, suggestions, and questions.
|
||
There are three options to enable the cron-job for Friendica: | ||
|
||
- Using the default Image and activate the cron-job (see [Installation](https://friendi.ca/resources/installation/), sector `Activating scheduled tasks`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to imply that users exec into their running friendica container and php bin/daemon.php start
to start cron? That is not a great solution since a container restart will stop the cron task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently there is no other option if you don't want to start an own cron-container. I can add an attention text to this option that you have to restart the cron manually each container restart (which is indeed not a very good solution ..)
I created a feature request for a better solution: friendica/friendica#8043
inkscape:label="Effects" | ||
style="display:inline"> | ||
<rect | ||
style="fill:url(#linearGradient3930);fill-opacity:1;stroke:none" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this linearGradient3930
is not defined elsewhere, which makes ImageMagick choke on this file:
convert-im6.q16: unrecognized color `linearGradient3930' @ warning/color.c/GetColorCompliance/1052.
convert-im6.q16: non-conforming drawing primitive definition `fill' @ error/draw.c/RenderMVGContent/4301.
convert-im6.q16: unrecognized color `linearGradient3930' @ warning/color.c/GetColorCompliance/1052.
convert-im6.q16: non-conforming drawing primitive definition `fill' @ error/draw.c/RenderMVGContent/4301.
Part of docker-library/official-images#6446 and friendica/docker#74