-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "--platform" to GHA generate script #81
Add "--platform" to GHA generate script #81
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #81 +/- ##
=======================================
Coverage 73.10% 73.10%
=======================================
Files 7 7
Lines 714 714
=======================================
Hits 522 522
Misses 162 162
Partials 30 30 |
https://github.com/tianon/dockerfiles/actions/runs/6190609199/job/16807227669 is an example failing job tianon/dockerfiles@ee0ab6c is where I've swapped in this commit for testing https://github.com/tianon/dockerfiles/actions/runs/6191900925 is the resulting failing job that's now failing in a more amusing way ("exec format error", because apparently I had erroneously assumed that GHA set up QEMU already by default 😂) |
So, I guess for things we can't build natively we can either:
At this point, I think I might be leaning towards the former, but I don't have a problem with doing the latter instead. Thoughts, @yosifkit? (either way, this really doesn't affect anyone I'm aware of except for me, lolsob) |
I guess option 3. is "both" and we make it environment-variable-configurable. |
This reverts commit 1801f6c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine as-is and I want #80 to build on top of it.
As is this doesn't actually solve my problem, but that can be a follow-up, I guess. Just need some input on which way to solve it 😅 |
I lean toward skipping as well. But then I feel like the most rational test (checking Alternatively, I am leaning toward just auto installing binfmt/qemu if the provided arch does not match |
This reverts commit 1801f6c.
I discovered this was missing when I created a riscv64-only image and it then failed to build on amd64. 😅
It should be totally harmless on most repos since I don't think anyone but me using this script has images that don't support one of either amd64 or windows-amd64, which will automatically be preferred. 🙈