This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e#382) Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
…mands; support for reading input from stdin for some commands Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Please sign your commits following these rules: $ git clone -b "yaml" [email protected]:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353866832
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: David Chung <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
- Coverage 68.13% 67.94% -0.19%
==========================================
Files 62 68 +6
Lines 3574 4065 +491
==========================================
+ Hits 2435 2762 +327
- Misses 934 1063 +129
- Partials 205 240 +35
Continue to review full report at Codecov.
|
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
…yaml Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Sep 30, 2017
Fix DDC nightly errors, picking manager instance size that is availab…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
-y
to use YAML.infrakit group commit <file>
has been changed to support a template or stdin, if the positional arg is-
.