Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

YAML support #457

Merged
merged 29 commits into from
Apr 3, 2017
Merged

YAML support #457

merged 29 commits into from
Apr 3, 2017

Conversation

chungers
Copy link
Contributor

@chungers chungers commented Apr 2, 2017

This PR

  • adds support for YAML as input through all CLI operations.
  • the CLI operations have been standardized to support templates.
  • templates can be in YAML or in JSON. The default is JSON. Use -y to use YAML.
  • Where positional args are taken as filename in the CLI (e.g. infrakit group commit <file> has been changed to support a template or stdin, if the positional arg is -.
  • Support for INI file decoding, used for decoding AWS credential files.

David Chung added 22 commits February 2, 2017 19:23
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
…mands; support for reading input from stdin for some commands

Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "yaml" [email protected]:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353866832
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: David Chung <[email protected]>
@codecov
Copy link

codecov bot commented Apr 2, 2017

Codecov Report

Merging #457 into master will decrease coverage by 0.18%.
The diff coverage is 23.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage   68.13%   67.94%   -0.19%     
==========================================
  Files          62       68       +6     
  Lines        3574     4065     +491     
==========================================
+ Hits         2435     2762     +327     
- Misses        934     1063     +129     
- Partials      205      240      +35
Impacted Files Coverage Δ
pkg/template/template.go 71.42% <ø> (ø)
pkg/template/funcs.go 67.77% <23.68%> (ø)
pkg/template/fetch.go 36.84% <0%> (ø)
pkg/template/defaults.go 71.42% <0%> (ø)
pkg/template/util.go 63.63% <0%> (ø)
pkg/template/help.go 67.34% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 843edf3...7b6ea04. Read the comment docs.

David Chung added 2 commits April 3, 2017 01:56
@chungers chungers merged commit 02d6425 into docker-archive:master Apr 3, 2017
@chungers chungers deleted the yaml branch April 3, 2017 09:24
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
Fix DDC nightly errors, picking manager instance size that is availab…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants