Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Handshake early to detect plugin version mismatch #369

Merged
merged 2 commits into from
Jan 19, 2017

Conversation

chungers
Copy link
Contributor

This PR is mostly a code refactor to let the RPC client error out early at construction time when there's a version mismatch.

  • This allows error to happen early before actual spi RPC calls are made.
  • A plugin implementation is still returned, even though future calls will fail unless the the version mismatch is addressed. We will consider adding mechanism for re-doing handshake thus allowing components to be swapped out on the fly without having to take everything down.

Signed-off-by: David Chung [email protected]

@codecov-io
Copy link

codecov-io commented Jan 19, 2017

Current coverage is 65.71% (diff: 76.66%)

Merging #369 into master will increase coverage by 0.29%

@@             master       #369   diff @@
==========================================
  Files            47         47          
  Lines          2284       2301    +17   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1494       1512    +18   
+ Misses          624        623     -1   
  Partials        166        166          

Powered by Codecov. Last update 21dc4cd...e29effc

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "plugin-handshake" [email protected]:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353454672
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@chungers chungers merged commit 61741dd into docker-archive:master Jan 19, 2017
@chungers chungers deleted the plugin-handshake branch January 19, 2017 22:10
@chungers chungers modified the milestone: v0.3 Jan 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants