Compose in go #919
Compose in go #919
Conversation
…mentation Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
…when starting a stack Signed-off-by: Djordje Lukic <[email protected]>
Signed-off-by: Djordje Lukic <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
local/containers.go
Outdated
| @@ -144,7 +145,10 @@ func (cs *containerService) Run(ctx context.Context, r containers.ContainerConfi | |||
| } | |||
|
|
|||
| func (cs *containerService) create(ctx context.Context, containerConfig *container.Config, hostConfig *container.HostConfig, networkingConfig *network.NetworkingConfig, name string) (string, error) { | |||
| created, err := cs.apiClient.ContainerCreate(ctx, containerConfig, hostConfig, networkingConfig, name) | |||
| created, err := cs.apiClient.ContainerCreate(ctx, containerConfig, hostConfig, networkingConfig, &v1.Platform{ | |||
There was a problem hiding this comment.
This cause error 1.41 is too new. Maximum supported API version is 1.40 on CI and on my Linux box :'(
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
compose-in-go
branch
from
64513c4 to
46cbb90
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
| } | ||
|
|
||
| for _, service := range project.Services { | ||
| err := s.applyPullPolicy(ctx, service) |
There was a problem hiding this comment.
Could we do this in parallel?
There was a problem hiding this comment.
Sure we can, I wonder there's any reason parallel_pull is set to False on docker/compose (https://github.com/docker/compose/blob/854c003359bd07d0d3ca137d7a08509cfeab0436/compose/project.py#L724)
Engine will download layers in parallel anyway
This whole thing will need to be revisited anyway with addition of build support (by importing some code from bake)
…first container logs for every container) Signed-off-by: Guillaume Tardif <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
There was a problem hiding this comment.
consts for compose labels could be a nice quick fix, I fixed a bug in logs... We could continue improving a lot of things but I'd rather merge this quickly and do follow up PRs, seems already plenty of features. (Will certainly need tests ta validate the many possible scenarios)
Signed-off-by: Nicolas De Loof <[email protected]>
What I did
Implemented compose for local backend
this is not feature-complete and is missing e2e coverage, but we'd like to avoid long-running branches
Related issue
docker/roadmap#15
(not mandatory) A picture of a cute animal, if possible in relation with what you did
