Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/test docker frontend #97

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Feature/test docker frontend #97

merged 4 commits into from
Oct 14, 2022

Conversation

leihuayi
Copy link
Contributor

@leihuayi leihuayi commented Oct 13, 2022 •
edited
Loading

  • Test that frontend image can build and run for PR workflow
  • Test that both frontend and backend can build and run for preprod workflow
  • Give a default value to WORKSPACE variable in docker-compose-prod (otherwise backend would fail)

@leihuayi leihuayi requested a review from djadeau October 13, 2022 16:09
@leihuayi leihuayi changed the base branch from main to develop October 13, 2022 16:09
@github-actions github-actions bot added the feature New feature / functionality label Oct 13, 2022
@leihuayi leihuayi linked an issue Oct 13, 2022 that may be closed by this pull request
Tests frontend #96
Closed
2 tasks
@leihuayi leihuayi removed a link to an issue Oct 13, 2022
Tests frontend #96
Closed
2 tasks
@leihuayi leihuayi linked an issue Oct 13, 2022 that may be closed by this pull request
Tests frontend #96
Closed
2 tasks
@leihuayi leihuayi marked this pull request as draft October 14, 2022 07:50
@leihuayi leihuayi marked this pull request as ready for review October 14, 2022 15:30
@leihuayi leihuayi merged commit 741ca53 into develop Oct 14, 2022
@leihuayi leihuayi deleted the feature/test-docker-frontend branch October 14, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djadeau djadeau djadeau approved these changes

@this-is-tobi this-is-tobi this-is-tobi approved these changes

Assignees
No one assigned
Labels
feature New feature / functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests frontend
3 participants
@leihuayi @this-is-tobi @djadeau