Enhancement/tf smart variables #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
titigmr
reviewed
May 19, 2022
titigmr
reviewed
May 19, 2022
| type = string | ||
| default = "main" | ||
| description = "Branch name to deploy" | ||
| } |
There was a problem hiding this comment.
Keep branch in tf variable because the deploy.sh script need this
There was a problem hiding this comment.
I don't understand, I thought the variables for deploy.sh should go in the env.json file ?
There was a problem hiding this comment.
true! but for this you need to add them into tfvars.json and remove TF_VAR_branch and TF_VAR_app vars
titigmr
reviewed
May 19, 2022
| type = string | ||
| default = "latest" | ||
| description = "Version to deploy" | ||
| } |
titigmr
reviewed
May 19, 2022
| @@ -35,9 +35,9 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: Build docker image for tests | |||
| run: docker build --target test -t basegun-back:tests backend/ | |||
| run: docker build --target test --build-arg VERSION=1.0 -t basegun-back:tests backend/ | |||
There was a problem hiding this comment.
otherwise the VERSION variable is not defined. Now it's done at build time instead of putting it in the environment at runtime. I changed this a while ago. I forgot to update this test which explains why the CI failed in the previous commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.