Enhancement/resize images #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leihuayi
suggested changes
Mar 31, 2022
There was a problem hiding this comment.
Currently it writes an image with extension .jpg, but in reality it writes file of type png, which is therefore much bigger in pixels (see second file) than the original file (see first file)
Actually I think you should not change the image type : if it is originally in png, keep in png, if it is in jpeg, keep in jpeg
leihuayi
approved these changes
Apr 1, 2022
leihuayi
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resizing images on client side, before it's sent to backend : biggest side (width or height) of picture uploaded by user is now 600px max.
Upload button moved to a separate component