Make docker images rootless #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashbrnrd
force-pushed
the
use-rootless-dockerfiles
branch
5 times, most recently
from
14c1c01 to
3e43f71
Compare
thomashbrnrd
changed the title
thomashbrnrd
force-pushed
the
use-rootless-dockerfiles
branch
4 times, most recently
from
6b20767 to
90e17d5
Compare
leihuayi
suggested changes
Aug 30, 2023
leihuayi
reviewed
Aug 30, 2023
thomashbrnrd
force-pushed
the
use-rootless-dockerfiles
branch
from
90e17d5 to
c210177
Compare
thomashbrnrd
force-pushed
the
use-rootless-dockerfiles
branch
from
c210177 to
59af920
Compare
thomashbrnrd
changed the title
thomashbrnrd
changed the title
thomashbrnrd
force-pushed
the
use-rootless-dockerfiles
branch
from
300988d to
629a160
Compare
thomashbrnrd
force-pushed
the
use-rootless-dockerfiles
branch
from
629a160 to
fa2d000
Compare
leihuayi
reviewed
Sep 4, 2023
| @@ -18,8 +18,6 @@ services: | |||
| image: basegun-backend:${TAG}-prod | |||
| ports: | |||
| - 5000:5000 | |||
| volumes: | |||
| - /var/log/basegun:/app/logs | |||
thomashbrnrd
force-pushed
the
use-rootless-dockerfiles
branch
2 times, most recently
from
c21e211 to
75565ee
Compare
thomashbrnrd
force-pushed
the
use-rootless-dockerfiles
branch
from
75565ee to
ed97da0
Compare
thomashbrnrd
force-pushed
the
use-rootless-dockerfiles
branch
from
9722e5f to
8f72ec8
Compare
thomashbrnrd
force-pushed
the
use-rootless-dockerfiles
branch
from
8f72ec8 to
bd03e18
Compare
leihuayi
approved these changes
Sep 6, 2023
thomashbrnrd
added a commit
that referenced
this pull request
Oct 24, 2023
* Make backend image rootless * Remove filebeat from docker-compose-prod.yml * Make frontend image rootless * Send logs to stdout * Remove tag question when using Makefile * Remove logs endpoint * Remove useless PATH_LOGS and CONTINUE=y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.