Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: ♻️ migrate components vue2 to vue3 #149

Merged
merged 5 commits into from
Mar 30, 2023
Merged

enh: ♻️ migrate components vue2 to vue3 #149

merged 5 commits into from
Mar 30, 2023

Conversation

NadeigeC
Copy link
Contributor

@NadeigeC NadeigeC commented Mar 22, 2023 •
edited
Loading

Fixes #139

  • Migrer en composition API (vue 3) les derniers composant qui ne l'étaient pas
  • Ajout d'un fichier .env pour stocker IPGEOLOCATION_API_KEY et IPGEOLOCATION_API_URL
  • Séparation des fonctions dans le composant UploadButton.vue

@NadeigeC NadeigeC added the enhancement Improvement of existing code w/o creating new feature label Mar 22, 2023
@NadeigeC NadeigeC requested a review from leihuayi March 22, 2023 13:11
@NadeigeC NadeigeC self-assigned this Mar 22, 2023
@NadeigeC NadeigeC force-pushed the enh/migrate-components-vue2-to-vue3 branch from 5b1065d to 36b46b0 Compare March 22, 2023 13:57
@NadeigeC NadeigeC changed the title ♻️ enh/migrate components vue2 to vue3 enh: ♻️ migrate components vue2 to vue3 Mar 23, 2023
@NadeigeC NadeigeC force-pushed the enh/migrate-components-vue2-to-vue3 branch 2 times, most recently from d4eed4d to 09cc73e Compare March 23, 2023 10:00
@NadeigeC NadeigeC changed the title enh: ♻️ migrate components vue2 to vue3 [WIPenh: ♻️ migrate components vue2 to vue3 Mar 23, 2023
@NadeigeC NadeigeC changed the title [WIPenh: ♻️ migrate components vue2 to vue3 [WIP] enh: ♻️ migrate components vue2 to vue3 Mar 23, 2023
@NadeigeC NadeigeC linked an issue Mar 27, 2023 that may be closed by this pull request
Réécrire en composition API les composants en vue 2 #139
Closed
@NadeigeC NadeigeC force-pushed the enh/migrate-components-vue2-to-vue3 branch 7 times, most recently from 391499b to 2c50ffe Compare March 29, 2023 12:10
@NadeigeC NadeigeC force-pushed the enh/migrate-components-vue2-to-vue3 branch from 2c50ffe to 70db1a8 Compare March 29, 2023 12:27
@NadeigeC NadeigeC force-pushed the enh/migrate-components-vue2-to-vue3 branch from 7a8d2cb to 1ca2394 Compare March 30, 2023 13:03
@NadeigeC NadeigeC changed the title [WIP] enh: ♻️ migrate components vue2 to vue3 enh: ♻️ migrate components vue2 to vue3 Mar 30, 2023
@NadeigeC NadeigeC merged commit d8767e1 into develop Mar 30, 2023
@NadeigeC NadeigeC deleted the enh/migrate-components-vue2-to-vue3 branch March 30, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leihuayi leihuayi Awaiting requested review from leihuayi

Assignees

@NadeigeC NadeigeC

Labels
enhancement Improvement of existing code w/o creating new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Réécrire en composition API les composants en vue 2
1 participant
@NadeigeC