Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 🎨 Refactoring HeaderMain with DsfrHeader component #144

Merged
merged 8 commits into from
Mar 30, 2023
Merged

refactor: 🎨 Refactoring HeaderMain with DsfrHeader component #144

merged 8 commits into from
Mar 30, 2023

Conversation

NadeigeC
Copy link
Contributor

@NadeigeC NadeigeC commented Mar 9, 2023 •
edited
Loading

Fixes #136

  • Migration vers vue-dsfr 3.3.0 (fix DsfrHeader quickLinks issue)
  • Ajout du composant dédiée DsfrHeader : remplacement du bouton Information par des liens
  • Ajout d'une icône d'information qui retourne à l'accueil (reco Nolwenn)
  • Changement de la couleur de la pagination active sur la page 2 du Swiper d'accueil (reco Nolwenn)
  • Suppression de la route, de la vue et des tabs Informations en mode desktop
  • Sur la page /consignes-de-securite typologie de l'arme mise en avant en orange (proposition @NadeigeC )

@NadeigeC NadeigeC added the enhancement Improvement of existing code w/o creating new feature label Mar 9, 2023
@NadeigeC NadeigeC requested a review from leihuayi March 9, 2023 11:34
@NadeigeC NadeigeC self-assigned this Mar 9, 2023
@NadeigeC NadeigeC changed the title refactor header main with vueDsfr component refactor: 🎨 Refactoring HeaderMain with DsfrHeader component Mar 9, 2023
@NadeigeC NadeigeC force-pushed the enh/refactoring-header-main-page branch from fb1b8dc to 6d93f50 Compare March 10, 2023 16:10
@NadeigeC NadeigeC mentioned this pull request Mar 24, 2023
Closed
@NadeigeC NadeigeC force-pushed the enh/refactoring-header-main-page branch from f0f59e1 to bd6ad4e Compare March 27, 2023 10:04
@NadeigeC NadeigeC linked an issue Mar 27, 2023 that may be closed by this pull request
Réécriture du composant <HeaderMain> en vue DSFR #136
Closed
@NadeigeC NadeigeC merged commit adf8c60 into develop Mar 30, 2023
@NadeigeC NadeigeC deleted the enh/refactoring-header-main-page branch March 30, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leihuayi leihuayi Awaiting requested review from leihuayi

Assignees

@NadeigeC NadeigeC

Labels
enhancement Improvement of existing code w/o creating new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Réécriture du composant <HeaderMain> en vue DSFR
1 participant
@NadeigeC