Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 🎨 Refactoring Result component #143

Merged
merged 1 commit into from
Mar 21, 2023
Merged

refactor: 🎨 Refactoring Result component #143

merged 1 commit into from
Mar 21, 2023

Conversation

NadeigeC
Copy link
Contributor

@NadeigeC NadeigeC commented Mar 9, 2023 •
edited
Loading

Fixes #135

@NadeigeC NadeigeC added the enhancement Improvement of existing code w/o creating new feature label Mar 9, 2023
@NadeigeC NadeigeC requested a review from leihuayi March 9, 2023 09:01
@NadeigeC NadeigeC self-assigned this Mar 9, 2023
@github-actions github-actions bot added the feature New feature / functionality label Mar 9, 2023
leihuayi
leihuayi approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@leihuayi leihuayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parfait !
Petit détail, mais pour le nom des branches, je préfèrerais qu'on utilise le préfixe "enh/" ou "enhancement/" pour le refactoring et qu'on garde "feat/" pour les fonctionnalités inédites.

@NadeigeC NadeigeC merged commit f15c2c8 into develop Mar 21, 2023
@NadeigeC NadeigeC deleted the feat/refactoring-result-page branch June 16, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leihuayi leihuayi leihuayi approved these changes

Assignees

@NadeigeC NadeigeC

Labels
enhancement Improvement of existing code w/o creating new feature feature New feature / functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NadeigeC @leihuayi