Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix empty localStorage on result page #132

Merged
merged 2 commits into from
Mar 6, 2023
Merged

fix empty localStorage on result page #132

merged 2 commits into from
Mar 6, 2023

Conversation

NadeigeC
Copy link
Contributor

@NadeigeC NadeigeC commented Feb 22, 2023 •
edited
Loading

Fix empty LocalStorage on result page. Redirect to start page.

Capture d’écran 2023-02-16 à 13 41 16

@NadeigeC NadeigeC added the bug Something isn't working label Feb 22, 2023
@NadeigeC NadeigeC self-assigned this Feb 22, 2023
@github-actions github-actions bot added the feature New feature / functionality label Feb 22, 2023
@NadeigeC NadeigeC force-pushed the feat/wip-fix-on-deploy-preprod branch from bce0391 to a9c037a Compare February 22, 2023 13:13
@NadeigeC NadeigeC force-pushed the feat/wip-fix-on-deploy-preprod branch from a9c037a to fc60e56 Compare February 22, 2023 17:04
@leihuayi leihuayi removed the feature New feature / functionality label Feb 23, 2023
@leihuayi
Copy link
Contributor

leihuayi commented Feb 24, 2023 •
edited
Loading

image

leihuayi
leihuayi suggested changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@leihuayi leihuayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai encore ce bug en faisant des allers-retours dans la navigation. Suggestion : rediriger vers la page d'accueil si l'image est undefined (à vérifier si ça fonctionne)

@github-actions github-actions bot added the feature New feature / functionality label Mar 6, 2023
@NadeigeC NadeigeC merged commit 5ab9ba1 into develop Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leihuayi leihuayi leihuayi approved these changes

Assignees

@NadeigeC NadeigeC

Labels
bug Something isn't working feature New feature / functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NadeigeC @leihuayi