Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOOM-101] 내 식물 전체 조회 api 수정 #102

Merged
merged 9 commits into from
Sep 8, 2024
Merged

Conversation

Dompoo
Copy link
Collaborator

@Dompoo Dompoo commented Sep 5, 2024

How

  • 해당 api의 query parameter인 locationId와 sort를 없앴습니다.
  • QueryDsl을 통해 제공받던 쿼리 대신에 JPQL을 통해 쿼리하도록 수정했습니다.
  • PlantResponse 객체에 locationId와 registeredDate 속성을 추가했습니다.

Result

  • 이제 프론트엔드에서는 전체 내 식물을 조회한 후, 직접 필터링/정렬하게 됩니다.
  • 쿼리 튜닝을 통해 이제 1쿼리 만으로 - 내 전체 식물/각 식물의 가장 최근에 등록한 즐겨찾기 사진/각 식물의 위치 를 조회할 수 있게 되었습니다.

@Dompoo Dompoo added the 🔨 fix Request a fix for an existing feature label Sep 5, 2024
@Dompoo Dompoo self-assigned this Sep 5, 2024
@Dompoo Dompoo requested a review from stophwan as a code owner September 5, 2024 02:11
@Dompoo Dompoo linked an issue Sep 5, 2024 that may be closed by this pull request
Copy link
Member

@stophwan stophwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 고생하셨습니다!!!

@Dompoo Dompoo merged commit b0d001a into main Sep 8, 2024
1 check passed
@Dompoo Dompoo deleted the fix/myplant-list branch September 18, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 fix Request a fix for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] 내 식물 전체 조회 api 수정
2 participants