Fix T1 site cores ResourceControl logic

[amaltaro]

Fixes #12121

Status

not-tested

Description

Given that Tier0 configuration sets this value <=100% (e.g. 12.5), the integer division would always return 0, hence not changing any of the default thresholds.

With the current change, we can now properly calculate a percentage of the site slots (e.g. 1250 for CNAF).

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

It has to go together with this T0 PR: dmwm/T0#5007

External dependencies / deployment changes

None

[dmwm-bot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 4 changes in unstable tests
• Python3 Pylint check: succeeded
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/93/artifact/artifacts/PullRequestReport.html

[mapellidario]

Sorry Alan, I fail to catch the rationale for this change.

Could you provide some example values for infoSSB[site]['slotsCPU'] before being updatesd and self.t1SitesCores ? is self.t1SitesCores set to an integer in the range [0, 100] and nobody noticed before that self.t1SitesCores // 100 always return 0? Which value should be <= 100%?

[amaltaro]

To be on the safe side, I am now casting the result to an integer.

Dario, no problem! Yes, the problem is that that division always return 0. I expected the multiplication to take precedence in that expression, but it looks like division goes first, bringing the result to 0, see:

>>> slotsCPU * t1SitesCores // 100
1250.0
>>> slotsCPU * (t1SitesCores // 100)
0.0

So I could actually have kept the integer division and simply enforce the precedence (plus casting, to be on the safe side, given that resource slots are integer).

[dmwm-bot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 1 tests added
  • 1 changes in unstable tests
• Python3 Pylint check: failed
  • 1 warnings and errors that must be fixed
  • 4 warnings
  • 8 comments to review
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/97/artifact/artifacts/PullRequestReport.html

[mapellidario]

Thanks Alan for the comment, thanks for the changes!

[amaltaro]

Antonio and I worked on vocms0502 resource control operational issues, and we ended up applying this patch to the agent.
Now T1 thresholds are looking Okay. With that, I am proceeding with the merge of this PR.