Fix typo - eval_metric in param should be dictionary #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see the first test in travis...do you know what happened? |
|
Not sure...seems new to me. |
|
@terrytangyuan I fixed the setup issue for cpplint, there will be other issues that need to be fixed |
|
Seems like the other issue is related to this merged PR #1781. I am not sure if it's ok to update the threshold in Python test since the test accuracy threshold change may indicate some problem. |
|
I think it is fine if it is just for poisson regression |
|
Thanks. I will fix it when get a chance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.