Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error raised when predicting or dumping count:poisson model #1236

Closed
yangs16 opened this issue May 31, 2016 · 3 comments
Closed

Error raised when predicting or dumping count:poisson model #1236

yangs16 opened this issue May 31, 2016 · 3 comments

Comments

@yangs16
Copy link
Contributor

yangs16 commented May 31, 2016

terminate called after throwing an instance of 'dmlc::ParamError'
what(): Required parameter max_delta_step of float is not presented
Aborted


An easy fix is to add a config item after the line 265 in src/learner.cc, e.g.
cfg_["max_delta_step"] = common::ToString(0.7);

Thanks.

@khotilov
Copy link
Member

khotilov commented Jun 4, 2016

cfg_["max_delta_step"] = "0.7";
should have taken care of that.
Could you please show how to reproduce your error?

@yangs16
Copy link
Contributor Author

yangs16 commented Jun 6, 2016

Yes. But the Configure() is not called in CLIDump2Text() and CLIPredict(). I guess the fix should be add a line after

std::unique_ptr<Learner> learner(Learner::Create({}));
and
std::unique_ptr<Learner> learner(Learner::Create({}));
:

learner->Configure(param.cfg);

Hope this will help.

@yangs16
Copy link
Contributor Author

yangs16 commented Jun 6, 2016

Just noticed that the problem with the prediction has been fixed in commit 1dde863. I send another pull request to fix the problem with the model dump: #1253

@tqchen tqchen closed this as completed Jul 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants