Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immediately update UI if just the calendar of an entry changes #6

Merged
merged 2 commits into from
Oct 20, 2017

Conversation

imario42
Copy link
Contributor

If you change just the "calendar" of an entry the change is not immediately reflected in the UI.

Steps to reproduce:

Start the CalendarFXSampler
Navigate to Performance/Performance
Switch layout to swimlane
create two entries at the same time at the same day
change the calendar of one entry .... nothings happens until you click the event

@imario42
Copy link
Contributor Author

Sorry, last PR was too fast. This one now works as expected

@dlemmermann
Copy link
Collaborator

Now I am confused. The second commit is basically the original. Why a pull request?

@imario42
Copy link
Contributor Author

imario42 commented Oct 20, 2017

PR#5 removed the isRelevant() from the evt.isEntryAdded condition - which was wrong.
PR#6 now restored that and just moved the requestLayout() out of this check into its own condition.
Thing is, we have to call requestLayout even if the entry has neither been removed nor added.

@dlemmermann dlemmermann merged commit 60ed612 into dlsc-software-consulting-gmbh:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants