Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Refactored unit test for the ConvolveMatrix. #1557

Merged
merged 3 commits into from
Feb 16, 2024
Merged

tests: Refactored unit test for the ConvolveMatrix. #1557

merged 3 commits into from
Feb 16, 2024

Conversation

Gounlaf
Copy link
Contributor

@Gounlaf Gounlaf commented Feb 16, 2024

👋

  • split ConvolveMatrixTests into multiple files like MagickColorMatrixTests
  • fix typo into MagickColorMatrixTests (IsNul() -> IsNull())

Regards.

@Gounlaf Gounlaf force-pushed the tests-refactor-convolvematrix branch from 5cb95da to 67378d4 Compare February 16, 2024 17:14
@Gounlaf Gounlaf changed the title tests: Refactored unit test for the ConvolveMatrixT. tests: Refactored unit test for the ConvolveMatrix. Feb 16, 2024
dlemstra
dlemstra approved these changes Feb 16, 2024
View reviewed changes
Copy link
Owner

@dlemstra dlemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refacotoring!

@dlemstra dlemstra merged commit 4c1a80f into dlemstra:main Feb 16, 2024
26 checks passed
@Gounlaf Gounlaf deleted the tests-refactor-convolvematrix branch February 16, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlemstra dlemstra dlemstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gounlaf @dlemstra