-
-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std.conv: add writeText, writeWText, writeDText #10652
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
Style check is going to fail because of dlang-community/D-Scanner#956 |
CC @LightBender |
Naming nit: |
The current names were chosen to be consistent with |
In v3 those methods are getting renamed. Likely to something like |
These are variants of text, wtext, and dtext that write their output to an output range instead of returning a string. Fixes dlang#10550
Ok; I'll assume you're bringing this up because you think that we should also follow this Phobos v3 naming convention when adding new symbols to Phobos v2, even if it breaks consistency with existing v2 symbols. |
c012310
to
be1db03
Compare
TBH, I've gone round and round on the idea of V2 names following the V3 conventions even if that breaks consistency, both with others and with myself. And where I've landed on it is: Every name that does not change between versions is one less bit of friction to the process of upgrading your code to V3. It's already going to be an unpleasant chore, anything that makes it easier will help convince people to make the switch. |
These are variants of text, wtext, and dtext that write their output to an output range instead of returning a string.
Fixes #10550