Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump liddoc and libdparse versions #834

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Jun 2, 2021

I'm trying to make dscanner use the latest versions of libddoc and libdparse to be able to recognize the AliasAssign declarations. This will unblock multiple phobos PRs such as [1]. Can someone, please provide some assistance as to what is necessary to make the phobos testing pipeline recognize the latest version of dscanner (the one with the latest versions of libddoc and libdparse).

Thanks!

[1] dlang/phobos#8040

@MoonlightSentinel
Copy link
Contributor

MoonlightSentinel commented Jun 2, 2021

Can someone, please provide some assistance as to what is necessary to make the phobos testing pipeline recognize the latest version of dscanner (the one with the latest versions of libddoc and libdparse).

Update DSCANNER_HASH in posix.mak.

Copy link
Member

@WebFreak001 WebFreak001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't update the submodule commit IDs yet

dub.json Outdated
@@ -12,11 +12,11 @@
"StdLoggerDisableWarning"
],
"dependencies" : {
"libdparse": ">=0.17.0 <0.18.0",
"libdparse": ">=0.18.0 <0.19.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.18.0 is only needed for new syntax, but not needed for any new analyzers. As older versions still work and may be used by other tools you should keep this lowered at 0.17.0 until there are new checks actually utilizing it.

@RazvanN7 RazvanN7 force-pushed the bump_versions branch 2 times, most recently from d4be4b4 to ee07815 Compare June 3, 2021 11:28
@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Jun 3, 2021

@WebFreak001 Done.

@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Jun 3, 2021

After bumping libddoc to the latest version I get in travis:

libddoc/src/ddoc/package.d(9): Error: module `sections` is in file 'ddoc/sections.d' which cannot be read

Looking into the repo it seems that package.d indeed imports ddoc.sections which doesn't exist.

This PR moves ddoc.sections to common/source/ddoc/sections.d but does not update ddoc.package.d. I wonder why travis didn't catch this.

cc @WebFreak001

@WebFreak001
Copy link
Member

@RazvanN7 ddoc:common defines the extra blocks: https://github.com/dlang-community/libddoc/tree/master/common/source/ddoc

As the root package depends on common unconditionally this move is fine, albeit a little harder to navigate. This seems to happen using libddoc as submodule, without DUB. I'm not sure if that's officially supported by libddoc, as it doesn't actually contain any build files to be built without dub itself. However to fix this, you need to simply add the libddoc/common/source folder to the import paths.

@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Jun 3, 2021

@WebFreak001 Thanks! Should be good now.

@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Jun 3, 2021

Update DSCANNER_HASH in posix.mak.

Thanks! Once this is merged, I will open a phobos PR.

@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Jun 4, 2021

@WebFreak001 Can we merge this?

@WebFreak001 WebFreak001 merged commit 2400d9c into dlang-community:master Jun 5, 2021
@Moth-Tolias
Copy link
Contributor

it seems this is still a problem.

running build.bat on the current master:

libddoc\src\ddoc\comments.d(7): Error: module `sections` is in file 'ddoc\sections.d' which cannot be read
import path[0] = libdparse\src
import path[1] = dsymbol\src
import path[2] = containers\src
import path[3] = libddoc\src
import path[4] = stdx-allocator\source
import path[5] = C:\D\dmd2\windows\bin\..\..\src\phobos
import path[6] = C:\D\dmd2\windows\bin\..\..\src\druntime\import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants