-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump liddoc and libdparse versions #834
Conversation
Update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't update the submodule commit IDs yet
dub.json
Outdated
@@ -12,11 +12,11 @@ | |||
"StdLoggerDisableWarning" | |||
], | |||
"dependencies" : { | |||
"libdparse": ">=0.17.0 <0.18.0", | |||
"libdparse": ">=0.18.0 <0.19.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.18.0 is only needed for new syntax, but not needed for any new analyzers. As older versions still work and may be used by other tools you should keep this lowered at 0.17.0 until there are new checks actually utilizing it.
d4be4b4
to
ee07815
Compare
@WebFreak001 Done. |
After bumping libddoc to the latest version I get in travis:
Looking into the repo it seems that package.d indeed imports This PR moves cc @WebFreak001 |
@RazvanN7 ddoc:common defines the extra blocks: https://github.com/dlang-community/libddoc/tree/master/common/source/ddoc As the root package depends on common unconditionally this move is fine, albeit a little harder to navigate. This seems to happen using libddoc as submodule, without DUB. I'm not sure if that's officially supported by libddoc, as it doesn't actually contain any build files to be built without dub itself. However to fix this, you need to simply add the libddoc/common/source folder to the import paths. |
@WebFreak001 Thanks! Should be good now. |
Thanks! Once this is merged, I will open a phobos PR. |
@WebFreak001 Can we merge this? |
it seems this is still a problem. running build.bat on the current master:
|
I'm trying to make dscanner use the latest versions of libddoc and libdparse to be able to recognize the AliasAssign declarations. This will unblock multiple phobos PRs such as [1]. Can someone, please provide some assistance as to what is necessary to make the phobos testing pipeline recognize the latest version of dscanner (the one with the latest versions of libddoc and libdparse).
Thanks!
[1] dlang/phobos#8040