refactor: prevent invoking setScrollPercent when trackScroll=false

dkaoster · Mar 24, 2024 · bbebcf1 · bbebcf1
1 parent 4818c3d
commit bbebcf1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/ScrollyVideo.js b/src/ScrollyVideo.js
@@ -475,6 +475,10 @@ class ScrollyVideo {
    * @param percentage
    */
   setScrollPercent(percentage) {
+    if (!this.trackScroll) {
+      return;
+    }
+
     const parent = this.container.parentNode;
     const { top, height } = parent.getBoundingClientRect();
 

diff --git a/src/ScrollyVideo.jsx b/src/ScrollyVideo.jsx
@@ -24,7 +24,6 @@ const ScrollyVideoComponent = forwardRef(function ScrollyVideoComponent(
 ) {
   const containerElement = useRef(null);
   const scrollyVideoRef = useRef(null);
-
   const [instance, setInstance] = useState(null);
 
   const videoPercentageRef = useRef(videoPercentage);
@@ -107,7 +106,7 @@ const ScrollyVideoComponent = forwardRef(function ScrollyVideoComponent(
     [instance],
   );
 
-  return <div ref={containerElement} />;
+  return <div ref={containerElement} data-scrolly-container />;
 });
 
 export default ScrollyVideoComponent;