Merge pull request #6 from djluck/visitor-bug-fix

Fixing bug that meant VectorSelector wasn't returned by the depth-fir…
djluck · Apr 29, 2022 · 7248e7d · 7248e7d
2 parents 507ce51 + 54e069b
commit 7248e7d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/PromQL.Parser/DepthFirstExpressionVisitor.cs b/src/PromQL.Parser/DepthFirstExpressionVisitor.cs
@@ -36,7 +36,7 @@ void IVisitor.Visit(UnaryExpr unary)
         void IVisitor.Visit(MatrixSelector ms)
         {
             _expressions.Add(ms);
-            // No need to visit vector selector, it's accessible from matrix selector
+            ms.Vector.Accept(this);
         }
 
         void IVisitor.Visit(OffsetExpr offset)

diff --git a/tests/PromQL.Parser.Tests/DepthFirstExpressionVisitorTests.cs b/tests/PromQL.Parser.Tests/DepthFirstExpressionVisitorTests.cs
@@ -40,6 +40,7 @@ public void Visit_Complex_Expression()
                         typeof(FunctionCall),
                         typeof(OffsetExpr),
                         typeof(MatrixSelector),
+                        typeof(VectorSelector),
                         typeof(UnaryExpr),
                         typeof(ParenExpression),
                         typeof(SubqueryExpr),