Use name instead of shortname for client definition

[cruelsmith]

Pull Request (PR) description

Use name instead of shortname in client definition for filename, firewall rule and huntgroup to allow the same shortname for different clients.

This Pull Request (PR) fixes the following issues

In some setups it may be needed that a client must be published multiple times with different ip addresses. In 1.x it was possible since it the client "name" was the IP itself. For 2.x the client "name" is now the shortname but there exist no definition that it needs to be uniq as far as we could found.

[nward]

Hi - this seems reasonable to me - I prefer use of name for things that have to be unique, like filenames, other resources, etc. rather than some other parameter on the define. @djjudas21 what do you think?

[djjudas21]

I'm happy to rubber-stamp this. Thanks for your contribution @cruelsmith

[djjudas21]

Quick question - what's the behaviour for people who are already running this and have configured clients? Will this leave orphaned files that might cause FreeRADIUS to behave oddly?

[cruelsmith]

@djjudas21 The client configs will be cleaned up by puppet since purge is defined:

puppet-freeradius/manifests/init.pp

Lines 99 to 100 in 3871bcc

	purge => true,
	recurse => true,

The freeradius::huntgroup will also be cleaned up because of the concat used for it.

For firewall the user is itself is responsible to configure it to be autocleaned up since it is out of scope of the module here. It only provide the firewall rules and nothing more.