[Feature] Implement mountpoint management #62
Conversation
First commit mountpoint tuning feature Delete mountpoint feature remove debug logs App state fix Mount new backend feature Fix merge conflict
|
Nice work @msessa-cotd. I'll take a look in a few hours. |
| > | ||
| {_.map(this.props.supportedBackendTypes, (b) => { | ||
| return (<MenuItem value={b} primaryText={b} />) | ||
| })} |
There was a problem hiding this comment.
Doesn't look like token types can be mounted:
{
_.map(this.props.supportedBackendTypes, (b) => {
if (b !== 'token') {
return (<MenuItem value={b} primaryText={b} />)
}
})
}
|
@msessa-cotd theres one thing that scares me with this feature: Its too easy to delete things. Yes, I understand there is a confirmation window so maybe i'm being paranoid, but it just seems too easy...thoughts? |
|
I'm just picturing someone somewhere accidentally deleting the |
|
I wouldn't worry too much. The delete button is already nested in the tune dialog, plus the delete confirmation is forced. All this on top of the fact that a user would need I don't believe it's vault-ui responsibility to make up for poorly configured vaults |
This PR adds mountpoint management to vault-ui.
Features:
Functionalities can be accessed via the left side menu.
The plus icon opens a new dialog to mount backends
The wrench icon opens a new dialog to tune mountpoint parameters and delete the