This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Policy Management #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
djenriquez
commented
Nov 9, 2016
djenriquez
commented
- Allow tokens with respective access to perform CRUD operations against policies
added 3 commits
November 8, 2016 14:19
alexunwin
approved these changes
Nov 9, 2016
|
|
||
| axios.put(`/policy?vaultaddr=${encodeURI(window.localStorage.getItem("vaultUrl"))}&policy=${encodeURI(policyName)}&token=${encodeURI(window.localStorage.getItem("vaultAccessToken"))}`, { "Policy": this.state.currentPolicy }) | ||
| .then((resp) => { | ||
| if (resp.status === 200) { |
There was a problem hiding this comment.
what is the point of this?
There was a problem hiding this comment.
placeholder, removed the 200 check though
| } | ||
|
|
||
| updatePolicy() { | ||
| let policyName = `${this.state.editingPolicy}`; |
There was a problem hiding this comment.
no need for interpolation here
| // Attempt to parse into JSON incase a stringified JSON was sent | ||
| try { | ||
| policy = JSON.parse(policy) | ||
| } catch(e) { } |
There was a problem hiding this comment.
you should log these errors
There was a problem hiding this comment.
its not meant to be an error, rather a check if the string is a valid json, and if it is, make it an object
| res.json(resp.data); | ||
| }) | ||
| .catch((err) => { | ||
| //console.error(err); |
added 3 commits
November 8, 2016 22:28
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.