This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Add ability to show current token + renew lease #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djenriquez
commented
May 1, 2017
| @@ -77,7 +129,16 @@ class Header extends React.Component { | |||
| </span> | |||
| ) | |||
|
|
|||
| if (this.props.tokenIdentity.ttl) { | |||
| if (this.state.tokenRenewed) { | |||
There was a problem hiding this comment.
Little bit of a hacky solution, but wasn't sure how to update the TTL once renewed since the value came from a super class. I'm definitely open to suggestions if there are better ways to handle this.
| <Divider /> | ||
| <MenuItem | ||
| primaryText="Logout" | ||
| onTouchTap={logout} |
There was a problem hiding this comment.
Logout is preserved and added to the icon menu.
|
@msessa thoughts on this one? |
|
@msessa @alexunwin Hey guys please take a look if you have time today, I'll be merging this in tonight. |
|
Merging in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #91, new functionality allows users to renew lease at any time from the new UI menu displayed at the top right.
In this menu, users now also have the ability to display the token they are currently using in order to use it for other tools that may require a Vault Token.
One thing I did notice that many users may become confused with, is the token renew process, which allows tokens to be renewed up to the maximum mount TTL. For a lot of users, their tokens may already be at max, in which case, this feature does nothing. Another thing I noticed is that when leases are renewed, they are automatically renewed to the mount's max TTL, rather then releasing for the initial TTL deployed. Not sure if this is how the Vault project meant to design these processes but this is how Vault works today. There could be other mount settings that can change these behaviors, but not sure what they are currently.
Reference: hashicorp/vault#1079