Canonicalize init --maildir argument after expanding #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that `maildir` is an absolute and _canonical_ path when user passes a custom maildir path using `mu init --maildir PATH`
|
Looks good, merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
when I tried to set up
muI ran into the following issue:I ran
mu init --maildir ~/mailwhich worked fine but when I tried to domu indexno mails where found. After some investigating I noticed
mustores my maildir as/home/USER//mailbut then disregards mails with the canonical path/home/USER/mail/...because they don't have this exact prefix.I thought it would make sense to store the maildir (which is already ensured to be absolute) as canonical path too and therefore canonicalize the
mu init --maildirargument after expanding.This fixes my problem, I hope it doesn't break something else. Feedback is appreciated. :)