Adds feature for users to customize connections created by the pool #89
Conversation
|
Overall this is looking good, thanks for working on it! |
|
I think this is ready for another look. Removing |
bb8/src/inner.rs
Outdated
| let conn = match shared.manager.connect().await { | ||
| Err(e) => Err(e), | ||
| Ok(mut c) => match self.on_acquire_connection(&mut c).await { | ||
| Err(e) => Err(e), | ||
| Ok(_) => Ok(c), | ||
| }, | ||
| }; |
There was a problem hiding this comment.
The repeated Err(e) => Err(e) arms can probably be factored out by using some combinators, can you look into that? And while you're in there, please add an empty line between first let conn = match and match conn { blocks?
There was a problem hiding this comment.
Updated. Looks a bit more compact.
|
This is looking good, some minor style things and then I think this is good to merge! |
|
Thanks! |
Co-authored-by: Antoine Gersant <[email protected]>
Co-authored-by: Antoine Gersant <[email protected]>
|
Is this supposed to run when the connection is first created, or every time it's checked out?
Also would be nice to document that it applies to |
Implementation for #88
I ended up running into not too many issues!