Removed unused *args from fields that use forms.RegexField #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkonrath
force-pushed
the
remove-args-regexfield
branch
from
ada8b85 to
f71e394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using positional arguments with fields that inherit from Django's
forms.RegexFieldpreviously only worked with Django 1.11 but were ignored with Django >= 2.0. This PR removes positional arguments from all fields that inherit from Django'sforms.RegexField. Any options needed on the parentforms.RegexField,forms.CharFieldorforms.Fieldmust now be set with keyword arguments.