Extend Danish post code field with small Danish islands #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reference Excel sheet from PostNord: https://www.postnord.dk/globalassets/danmark/.excel-docs/postnummerfil-til-download-06-19.xlsx |
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
=======================================
Coverage 95.85% 95.85%
=======================================
Files 161 161
Lines 3978 3978
Branches 530 530
=======================================
Hits 3813 3813
Misses 99 99
Partials 66 66
Continue to review full report at Codecov.
|
benkonrath
requested changes
Jul 12, 2019
|
@benkonrath Thank you for the comment, I've updated the PR as per your suggestion. Let me know if it's OK, and I'll squash everything. |
benkonrath
approved these changes
Jul 12, 2019
|
Looks good. |
HenrikOssipoff
force-pushed
the
add-small-danish-islands-to-postcode-db
branch
from
f92aee0 to
72dea1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2017 a lot of small Danish islands gained their own independant postal codes, which were missing from
DK_POSTCALCODES. Also added 3 new service postal codes (ones below 1000).All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.