Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ie model fields - rebase #366

Merged
merged 2 commits into from
Apr 28, 2019
Merged

ie model fields - rebase #366

merged 2 commits into from
Apr 28, 2019

Conversation

benkonrath
Copy link
Member

This PR contains the code by @paulcunnane in #360 rebased to master. I started doing a review but after my investigation I had 80% of the updates done so I thought I'd just finish it.

Changes:

  • Convert to using RegexField
  • Remove space from regex so that it accepts Eircodes without spaces
  • Add a display format with a space
  • Use the the built-in strip option

@paulcunnane Could you test this version out to make sure it's working well?

Closes #360

@benkonrath benkonrath changed the title ie model fields ie model fields - rebase Mar 23, 2019
@codecov-io
Copy link

Codecov Report

Merging #366 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   95.97%   95.98%   +0.01%     
==========================================
  Files         158      158              
  Lines        4022     4039      +17     
  Branches      523      525       +2     
==========================================
+ Hits         3860     3877      +17     
  Misses         98       98              
  Partials       64       64
Impacted Files Coverage Δ
localflavor/ie/forms.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5952106...c6bd092. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 23, 2019

Codecov Report

Merging #366 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   95.95%   95.96%   +0.01%     
==========================================
  Files         160      160              
  Lines        4051     4068      +17     
  Branches      525      527       +2     
==========================================
+ Hits         3887     3904      +17     
  Misses         99       99              
  Partials       65       65
Impacted Files Coverage Δ
localflavor/ie/forms.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cbf596...0992730. Read the comment docs.

@benkonrath benkonrath added this to the 2.2 milestone Apr 22, 2019
@benkonrath benkonrath force-pushed the paulcunnane-ie-model-fields branch from c6bd092 to e03b18b Compare April 28, 2019 18:55
@benkonrath benkonrath force-pushed the paulcunnane-ie-model-fields branch from e03b18b to 0992730 Compare April 28, 2019 18:59
@benkonrath
Copy link
Member Author

I assume this is working since the tests still pass after my changes. I'm going to merge this so that it's in the 2.2 release - we can always make changes if it needs to be adjusted for some reason.

@benkonrath benkonrath merged commit 0ff23bb into master Apr 28, 2019
@benkonrath benkonrath deleted the paulcunnane-ie-model-fields branch April 28, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants