Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #210 -- Added VAT identifcation number validator #324

Merged
merged 1 commit into from
Feb 10, 2018

Conversation

codingjoe
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 30, 2017

Codecov Report

Merging #324 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   95.87%   95.88%   +0.01%     
==========================================
  Files         153      153              
  Lines        3804     3818      +14     
  Branches      507      508       +1     
==========================================
+ Hits         3647     3661      +14     
  Misses         96       96              
  Partials       61       61
Impacted Files Coverage Δ
localflavor/generic/validators.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 910d128...d47d970. Read the comment docs.

@codingjoe
Copy link
Contributor Author

ping @benkonrath

@benkonrath
Copy link
Member

I'll be able to look at this in a couple of days.

Copy link
Member

@benkonrath benkonrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this - life has been keeping me busy these days.

It looks good. Could you rebase this and add a changelog entry and your name to the authors file if it's not already there? Thanks.

@benkonrath benkonrath added this to the 2.1 milestone Feb 6, 2018
@codingjoe
Copy link
Contributor Author

@benkonrath I added the author and change log entry.

@benkonrath benkonrath merged commit c0cb32b into django:master Feb 10, 2018
@codingjoe codingjoe deleted the vatin branch February 13, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants