-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added areas in Kuwait #296
Conversation
i dont know why but the sorry if i missed something this is the first time i contribute here please let me know if something is missing |
are there any core contributors that can help me with this PR? i dont know why it is failing |
Hey Hamad, |
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=========================================
+ Coverage 96.29% 96.3% +<.01%
=========================================
Files 151 152 +1
Lines 4214 4221 +7
Branches 579 579
=========================================
+ Hits 4058 4065 +7
Misses 97 97
Partials 59 59
Continue to review full report at Codecov.
|
Thank you @claudep I have reverted what
|
You can grep the code for |
@claudep alright done 👍 thanks for your help 😄 |
Merged via e51e52f. Thanks! |
Please replace these instructions with a description of your change. The
'New Fields Only' section should be removed if your pull request
doesn't add any new fields.
Thanks for your contribution!
A checklist is included below which helps us keep the code contributions
consistent and helps speed up the review process. You can add additional
commits to your pull request if you haven't met all of these points on your
first version.
All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.
Adjust your imports to a standard form by running this command:
New Fields Only
Prefix the country code to all fields.
Field names should be easily understood by developers from the target
localflavor country. This means that English translations are usually
not the best name unless it's for something standard like postal code,
tax / VAT ID etc.
Add meaningful tests. 100% test coverage is not required but all
validation edge cases should be covered.
Add
.. versionadded:: <next-version>
comment markers to newlocalflavors.
Add documentation for all fields.