Fix saving a single space for empty postcode value. #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also applies the `len(value)` logic found in the formfield `NLZipCodeField.clean()` to be more rubust.
|
Looks good to me. |
benkonrath
requested changes
Mar 6, 2017
There was a problem hiding this comment.
Thanks @vdboor. This PR just needs an entry to the changelog and your name added to the authors file.
vdboor
added a commit
to vdboor/django-localflavor
that referenced
this pull request
Mar 6, 2017
|
@benkonrath I've added the entry! :-) I was a bit confused about the Chicken & Egg issue to add a changelog for a PR that I didn't submit yet. |
benkonrath
approved these changes
Mar 6, 2017
|
Yeah, you just have to follow up with a second commit for the changelog entry. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
NLZipCodeFieldcontains an empty string, it saves an empty space instead.This PR updates the test code to check this, and provides the fix.
I've also applied
len(value)logic found in the formfieldNLZipCodeField.clean()so the models'to_python()becomes more rubust.