Add Australian Company Number validator #278
Conversation
tests/test_au/tests.py
Outdated
|
|
||
| def test_raises_error_for_whitespace(self): | ||
| """Test an ACN can be valid when it contains whitespace.""" | ||
| # NB: Form field should strip the whitespace before regex valdation is run. |
There was a problem hiding this comment.
valdation -> validation
I see that's also in the copy & pasted code so maybe you can also fix the typo there as well.
As this comment points out, the whitespace is stripped in the form. It would be nice to have a test for the form as well - at least testing the expected functionality that isn't tested with the validation tests.
tests/test_au/tests.py
Outdated
|
|
||
| validator = AUCompanyNumberFieldValidator() | ||
|
|
||
| validator(valid_acn) |
There was a problem hiding this comment.
It would be nice to be consistent on the spacing. For instance, some tests have a space between each statement while one has no spaces. The space don't seem to be needed because it's pretty simple code. Feel free to fix the previous tests as well where this was copied from.
|
Fixed both issues. |
|
It would be great if you can also add a test the form's |
|
Added tests. |
Add Australian Company Number model and form fields.
Note that running
isort --recursive --line-width 120 localflavor testsproduced changes in otherwise unchanged files. I've limited my changes to the files I touched.All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.
Adjust your imports to a standard form by running this command:
New Fields Only
Prefix the country code to all fields.
Field names should be easily understood by developers from the target
localflavor country. This means that English translations are usually
not the best name unless it's for something standard like postal code,
tax / VAT ID etc.
Prefer 'PostalCodeField' for postal codes as it's
international English; ZipCode is a term specific to the United
States postal system.
Add meaningful tests. 100% test coverage is not required but all
validation edge cases should be covered.
Add
.. versionadded:: <next-version>comment markers to newlocalflavors.
Add documentation for all fields.