Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalized versions of COFA state names #277

Merged
merged 1 commit into from
Feb 21, 2017

Conversation

elliottcf
Copy link
Contributor

I added the COFA_STATES names in a few forms to the STATES_NORMALIZED dict.

We needed this so we could use the localflavor.us.forms.USStateField in a form which accepts COFA locations.

I ran tox even though I was just adding a few more entries to an existing dict.

@elliottcf elliottcf force-pushed the add-normalized-cofa-states branch from 0bd74c7 to a835b77 Compare February 16, 2017 16:52
elliottcf added a commit to elliottcf/django-localflavor that referenced this pull request Feb 16, 2017
@elliottcf
Copy link
Contributor Author

elliottcf commented Feb 16, 2017

I just squashed my commits to make it easier to merge.
Let me know if there is anything else I should do.

@benkonrath
Copy link
Member

Thanks for your contribution. Could you update the comment in the USStateField to mention that the US territories and the COPA countries are also included in the validation.

For anybody who's following and interested, this video explains how the US territories and the COPA countries are organized.
https://www.youtube.com/watch?v=ASSOQDQvVLU

@elliottcf elliottcf force-pushed the add-normalized-cofa-states branch from a835b77 to 1218936 Compare February 17, 2017 16:22
@elliottcf
Copy link
Contributor Author

I updated the USStateField comment to mention the additional territories it validates.
I also squashed my commits into one.

@benkonrath benkonrath merged commit aa14ada into django:master Feb 21, 2017
@benkonrath
Copy link
Member

Thanks again for your contribution!

@elliottcf elliottcf deleted the add-normalized-cofa-states branch February 22, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants