refactoring field to inherit from RegexField #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burhan
force-pushed
the
kw-civil-id-refactor
branch
2 times, most recently
from
eae7f1f to
d733bea
Compare
|
|
||
| def has_valid_checksum(value): |
There was a problem hiding this comment.
Since you're making this a public function, you should rename this to be more meaningful. kw_civil_id_number_has_valid_checksum could work but I'm also open to other suggestions.
burhan
force-pushed
the
kw-civil-id-refactor
branch
from
d733bea to
ccdd2ac
Compare
|
@burhan Can you rebase this with master so that it can be merged? Thanks. |
burhan
force-pushed
the
kw-civil-id-refactor
branch
from
ccdd2ac to
8770f80
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #195 - this PR refactors the field to inherit from RegexField; further it simplifies the regular expression as well.