Add deconstruct to model fields #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format is cribbed from the `deconstruct` method's documentation, which provides clear examples for how to write these methods. To do this, I needed to import the models into the tests, which created some fun namespace problems.
|
The Python 3.2 test failure only happens with the Travis version of Python 3.2.5. I can't reproduce the problem on my local system with Python 3.2.6. I need to think about how I can get around this but the general PR is still ready for feedback. |
benkonrath
force-pushed
the
add-deconstruct-to-models
branch
from
9cbbff3 to
906f160
Compare
|
Tests are now passing. |
benkonrath
force-pushed
the
add-deconstruct-to-models
branch
from
906f160 to
8ffa807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the @mlissner's commit in PR #162. I've added a deconstruct method to all model fields. I've also added a generic test for the deconstruct as well as a test for the options in the IBAN Field. It would be great if somebody could review this and provide feedback. Thanks.
Closes #162