Fix problem in ES validating NIE numbers starting with Y and Z. #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thanks! Can you just add a couple of housekeeping items:
Thanks. |
|
Done! I hope everything is fine now. Many thanks for the kind help! |
|
Looks good. Can you just rebase from master and squash the commits? Thanks! |
|
I took care of the rebase and squash. I also fixed a small issue with changelog. Thanks for your help. Please do send in more fixes if you find anymore problems. Fixed via e37786d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago this ticket was opened but not correctly fixed.
The checksum should be calculated by prepending the index of the first letter. More reference can be found here: https://es.wikipedia.org/wiki/N%C3%BAmero_de_identificaci%C3%B3n_fiscal#D.C3.ADgito_de_control_para_n.C3.BAmeros_de_DNI_o_NIE