Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hungarian Counties select widget #213

Closed
wants to merge 1 commit into from
Closed

Conversation

rlaszlo
Copy link
Contributor

@rlaszlo rlaszlo commented Apr 2, 2016

No description provided.

@benkonrath
Copy link
Member

Thanks, this looks great. I'll merge this tomorrow at the DjangoCon EU sprints and you can hit the gong!

@benkonrath
Copy link
Member

@rlaszlo Just one small request that I forgot about. Can you add an entry to the changelog about this new localflavor? Thanks!



class HUCountySelect(Select):
"""A Select widget that uses a list of Hungarian Counties as its choices."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a .. versionadded:: 1.3` to this comment. Thanks.

@rlaszlo
Copy link
Contributor Author

rlaszlo commented Apr 3, 2016

Hi @benkonrath ! The pull request is now in the changelog.rst and I put the version in the forms too. Thanks!

@benkonrath
Copy link
Member

Fixed via b0b3641.

@benkonrath benkonrath closed this Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants